SuccessChanges

Summary

  1. Core plugin: some minor improvement to the reloading of a file. (commit: 4032c43) (details)
  2. Some minor cleaning up. (commit: 139c46e) (details)
  3. Some minor cleaning up. (commit: 6a2ff90) (details)
  4. Main window: slight improvement to the way we use the Core plugin. (commit: 3d2728f) (details)
  5. Now track our Simulation Support plugin (#1630). (commit: 073babe) (details)
  6. Simulation Support plugin: removed our handling of the File Handling (commit: e78cc0b) (details)
  7. Central widget: get our Simulation Support plugin to save/rename/reload (commit: ec44d1f) (details)
  8. Simulation Support plugin: removed our handling of the File Handling (commit: c7ac2de) (details)
  9. Simulation support: simplified our Simulation interface and put back our (commit: 9b9e721) (details)
  10. Simulation support: make sure that we have a data store before returning (commit: 72f0c7e) (details)
  11. Simulation support: we should really not have to reset our various (commit: e575371) (details)
  12. Simulation Experiment view: a simulation shouldn't be stopped by the (commit: ae46194) (details)
  13. Simulation support: properly handle the generation of elapsed time (commit: a6b822a) (details)
  14. Simulation Experiment view: only update our progress bar or our tab icon (commit: 74c127f) (details)
  15. Graph Panel widget: improved the alignment of a graph panel with its (commit: 9920ff9) (details)
  16. Revert "Graph Panel widget: improved the alignment of a graph panel with (commit: af9451e) (details)
  17. Graph Panel widget: improved the alignment of a graph panel with its (commit: c927305) (details)
  18. Revert "Graph Panel widget: improved the alignment of a graph panel with (commit: 0ba67a8) (details)
  19. Graph Panel widget: improved the alignment of a graph panel with its (commit: 609b4d5) (details)
  20. Simulation Experiment view: don’t consider a SED-ML file as modified (commit: a6ca926) (details)
  21. macOS: added support for exiting full-screen mode when pressing the Esc (commit: e3f8fa2) (details)
  22. Slight update to our downloads page (#1637). (commit: 9900b4b) (details)
  23. Some minor cleaning up. (commit: 71345a0) (details)
  24. Some minor cleaning up. (commit: 283808b) (details)
  25. CellML support: have `CellmlFile::runtime()` always return a brand new (commit: bd5ab3f) (details)
  26. Removed our Simulation interface since we don't need it anymore (thanks (commit: f4fd1c7) (details)
  27. Removed our Simulation interface since we don't need it anymore (thanks (commit: 2b522b4) (details)
  28. Some minor cleaning up. (commit: bb86b4c) (details)
  29. Removed our Simulation interface since we don't need it anymore (thanks (commit: 788fb8b) (details)
  30. CellML support: have `CellmlFile::runtime()` always return a brand new (commit: a309360) (details)
  31. Simulation Experiment view: make sure that a simulation is stopped when (commit: 7d768fc) (details)
  32. Simulation Experiment view: prevent the third crash in issue #1630. (commit: 055ac53) (details)
  33. Simulation support: actually wait for our worker thread to be done when (commit: ce19ce3) (details)
  34. Some minor cleaning up. (commit: 40bd885) (details)
  35. Simulation Experiment view: prevent the fourth crash in issue #1630. (commit: fe30413) (details)
  36. Some minor cleaning up. (commit: 60f8b53) (details)
  37. Some minor cleaning up. (commit: 9e8e58d) (details)
  38. Some minor cleaning up. (commit: b7a9f62) (details)
  39. Simulation Experiment view: prevent the second crash in issue #1630. (commit: 8e4b0c2) (details)
  40. Some minor cleaning up. (commit: 39d3416) (details)
  41. Some cleaning up. (commit: 7a4752a) (details)
  42. Some minor cleaning up. (commit: f87fedc) (details)
  43. Some minor cleaning up. (commit: 5b16f9b) (details)
Commit 4032c43525892075e128e5faf4168ab5cfc9be2f by Alan Garny
Core plugin: some minor improvement to the reloading of a file.
(commit: 4032c43)
The file was modifiedsrc/plugins/miscellaneous/Core/src/centralwidget.cpp (diff)
The file was modifiedsrc/plugins/miscellaneous/Core/src/filemanager.cpp (diff)
The file was modifiedsrc/mainwindow.cpp (diff)
The file was modifiedsrc/mainwindow.h (diff)
Commit 3d2728f9b3ad8c9bc4375844134081e21e081033 by Alan Garny
Main window: slight improvement to the way we use the Core plugin.
(commit: 3d2728f)
The file was modifiedsrc/mainwindow.h (diff)
The file was modifiedsrc/mainwindow.cpp (diff)
Commit 073babedc85acfdbbc94b004fe0f91d2876aad94 by Alan Garny
Now track our Simulation Support plugin (#1630).
(commit: 073babe)
The file was addedsrc/plugins/simulationinterface.cpp
The file was addedsrc/plugins/simulationinterface.h
The file was modifiedsrc/plugins/support/SimulationSupport/CMakeLists.txt (diff)
The file was modifiedsrc/plugins/miscellaneous/Core/src/centralwidget.cpp (diff)
The file was modifiedsrc/plugins/miscellaneous/Core/src/centralwidget.h (diff)
The file was modifiedsrc/plugins/plugin.cpp (diff)
The file was modifiedsrc/plugins/plugin.h (diff)
The file was addedsrc/plugins/simulationinterface.inl
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationsupportplugin.cpp (diff)
The file was modifiedsrc/plugins/miscellaneous/Core/CMakeLists.txt (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationsupportplugin.h (diff)
The file was modifiedCMakeLists.txt (diff)
The file was modifiedsrc/plugins/pluginmanager.cpp (diff)
The file was modifiedsrc/plugins/pluginmanager.h (diff)
Commit e78cc0b26b43fe7cfd811368b71d4fa6581f886a by Alan Garny
Simulation Support plugin: removed our handling of the File Handling
interface (#1630).
(commit: e78cc0b)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationsupportplugin.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationsupportplugin.h (diff)
Commit ec44d1f374bc6d10dade839808011e4bd9c438b7 by Alan Garny
Central widget: get our Simulation Support plugin to save/rename/reload
a file before our file manager (#1630).
(commit: ec44d1f)
The file was modifiedsrc/plugins/miscellaneous/Core/src/centralwidget.cpp (diff)
Commit c7ac2deabc68b67dadb85205ad36a695db905d33 by Alan Garny
Simulation Support plugin: removed our handling of the File Handling
interface (#1630).
(commit: c7ac2de)
The file was modifiedsrc/plugins/support/SimulationSupport/CMakeLists.txt (diff)
Commit 9b9e72103a34e7882a59eefb47b33577da2ad90f by Alan Garny
Simulation support: simplified our Simulation interface and put back our
handling of the File Handling interface (#1630).
Indeed, the only thing we need to do (and should be doing) as soon as
possible is stop the simulation. Once this is done, we can retrieve our
file details when a SED-ML/CellML file has been reloaded. To retrieve
our file details just after stopping a simulation will result in our
file details being wrong since a SED-ML/CellML file will have reloaded
yet.
(commit: 9b9e721)
The file was modifiedsrc/plugins/miscellaneous/Core/src/centralwidget.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/CMakeLists.txt (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationmanager.cpp (diff)
The file was modifiedsrc/plugins/simulationinterface.inl (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationsupportplugin.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationmanager.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationsupportplugin.cpp (diff)
Commit 72f0c7eb65f55a9b09720119b6ac7405c98a842a by Alan Garny
Simulation support: make sure that we have a data store before returning
our number of runs (#1630).
This is needed, for example, when a simulation was running and then we
reloaded a SED-ML file as a result of its corresponding CellML file
having been modified.
(commit: 72f0c7e)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
Commit e5753716a9342478b080c83978038c26798ed0f7 by Alan Garny
Simulation support: we should really not have to reset our various
arrays in SimulationData::deleteArrays().
Indeed, we should only ever come here once, so…
(commit: e575371)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
Commit ae461947e28ed584570b2f73b857f1ceaf8ef2df by Alan Garny
Simulation Experiment view: a simulation shouldn't be stopped by the
Simulation Experiment view (#1630).
When a simulation needs to be stopped, it should be stopped before doing
anything else (e.g. reloading a file) since it’s run in its own thread.
So, anything else will result in a potential crash of OpenCOR. This is
the reason we now stop a simulation from within our central widget.
(commit: ae46194)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewsimulationwidget.cpp (diff)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewsimulationwidget.h (diff)
Commit a6b822a0b3350214360fcbae89c132fa01c7f359 by Alan Garny
Simulation support: properly handle the generation of elapsed time
(#1630).
(commit: a6b822a)
The file was modifiedsrc/plugins/miscellaneous/Core/src/centralwidget.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationmanager.h (diff)
The file was modifiedsrc/plugins/simulationinterface.inl (diff)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewsimulationwidget.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationsupportplugin.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationworker.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationmanager.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationworker.cpp (diff)
Commit 74c127ff82bb88c6fdf0ac4299e2159072a62718 by Alan Garny
Simulation Experiment view: only update our progress bar or our tab icon
if needed (#1630).
(commit: 74c127f)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewsimulationwidget.cpp (diff)
Commit 9920ff9a07c903c8900154eb68ca1eb9702bee5d by Alan Garny
Graph Panel widget: improved the alignment of a graph panel with its
neighbours.
Indeed, when running the model in issue #1630, the X axis of the first
graph panel was flashing for a bit before becoming “stable”. This was
due to us calling xScaleWidget->setMinBorderDist(0, 0), which unlike our
call to yScaleDraw->setMinimumExtent(0.0), we don’t seem to need to
properly align our graph panels.
(commit: 9920ff9)
The file was modifiedsrc/plugins/widget/GraphPanelWidget/src/graphpanelplotwidget.cpp (diff)
Commit af9451ef86e8c3c11d2d6c81e2c2fc2f4b2d6d13 by Alan Garny
Revert "Graph Panel widget: improved the alignment of a graph panel with
its neighbours."
This reverts commit 9920ff9a07c903c8900154eb68ca1eb9702bee5d.
(commit: af9451e)
The file was modifiedsrc/plugins/widget/GraphPanelWidget/src/graphpanelplotwidget.cpp (diff)
Commit c927305cc668a4b5aeb1c05f5ae127db59f2abf6 by Alan Garny
Graph Panel widget: improved the alignment of a graph panel with its
neighbours on macOS.
Indeed, when running the model in issue #1630 on macOS, the X axis of
the first graph panel was flashing for a bit before becoming "stable".
This was due to us calling xScaleWidget->setMinBorderDist(0, 0), which
unlike our call to yScaleDraw->setMinimumExtent(0.0), we don’t seem to
need to properly align our graph panels (at least, on macOS).
(commit: c927305)
The file was modifiedsrc/plugins/widget/GraphPanelWidget/src/graphpanelplotwidget.cpp (diff)
Commit 0ba67a863e42b14b3bf020b5aa5bd7eb9993f4fb by Alan Garny
Revert "Graph Panel widget: improved the alignment of a graph panel with
its neighbours on macOS."
This reverts commit c927305cc668a4b5aeb1c05f5ae127db59f2abf6.
(commit: 0ba67a8)
The file was modifiedsrc/plugins/widget/GraphPanelWidget/src/graphpanelplotwidget.cpp (diff)
Commit 609b4d5cb341f9e0d23e8f3f6e7d1da1ad1059e5 by Alan Garny
Graph Panel widget: improved the alignment of a graph panel with its
neighbours.
Indeed, when running the model in issue #1630, the X axis of the first
graph panel was flashing on macOS for a bit before becoming "stable",
due to our call to xScaleWidget->setMinBorderDist(0, 0). So, we had to
find another way of doing things without that call...
(commit: 609b4d5)
The file was modifiedsrc/plugins/widget/GraphPanelWidget/src/graphpanelplotwidget.cpp (diff)
Commit a6ca92678bda36056699c01af60a837ab53f211b by Alan Garny
Simulation Experiment view: don’t consider a SED-ML file as modified
under certain conditions (#1626).
(commit: a6ca926)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewsimulationwidget.cpp (diff)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewsimulationwidget.h (diff)
Commit e3f8fa2f7b6270dbed3d36c6d8fd06fd517840e8 by Alan Garny
macOS: added support for exiting full-screen mode when pressing the Esc
key (#1637).
(commit: e3f8fa2)
The file was modifiedsrc/mainwindow.cpp (diff)
The file was modifiedsrc/mainwindow.h (diff)
Commit 9900b4ba7a8ad8adf7cd7a6cd8f191322e0f661f by Alan Garny
Slight update to our downloads page (#1637).
(commit: 9900b4b)
The file was modifieddoc/downloads/index.js (diff)
The file was modifiedsrc/plugins/support/CellMLSupport/src/cellmlfileruntime.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationworker.h (diff)
Commit bd5ab3f99b699887c5e5a97fa7e84b63a148ab0e by Alan Garny
CellML support: have `CellmlFile::runtime()` always return a brand new
runtime (#1630).
The idea is that whoever calls `CellmlFile::runtime()` is responsible
for deleting that runtime once it’s done with it.
(commit: bd5ab3f)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
The file was modifiedsrc/plugins/support/CellMLSupport/src/cellmlfileruntime.cpp (diff)
The file was modifiedsrc/plugins/support/CellMLSupport/src/cellmlfile.cpp (diff)
The file was modifiedsrc/plugins/support/CellMLSupport/src/cellmlfile.h (diff)
The file was modifiedsrc/plugins/support/CellMLSupport/src/cellmlfileruntime.h (diff)
Commit f4fd1c73ed73e019c465e25fa7dd1738956679a8 by Alan Garny
Removed our Simulation interface since we don't need it anymore (thanks
to commit bd5ab3f; #1630).
(commit: f4fd1c7)
The file was modifiedsrc/plugins/pluginmanager.cpp (diff)
The file was modifiedsrc/plugins/miscellaneous/Core/src/centralwidget.cpp (diff)
The file was modifiedsrc/plugins/miscellaneous/Core/src/centralwidget.h (diff)
The file was removedsrc/plugins/simulationinterface.cpp
The file was modifiedCMakeLists.txt (diff)
The file was modifiedsrc/plugins/plugin.cpp (diff)
The file was removedsrc/plugins/simulationinterface.inl
The file was removedsrc/plugins/simulationinterface.h
The file was modifiedsrc/plugins/miscellaneous/Core/CMakeLists.txt (diff)
The file was modifiedsrc/plugins/plugin.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationsupportplugin.h (diff)
The file was modifiedsrc/plugins/pluginmanager.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationsupportplugin.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/CMakeLists.txt (diff)
Commit 2b522b444213aaa4cb5c69f871d36ca9a09a0221 by Alan Garny
Removed our Simulation interface since we don't need it anymore (thanks
to commit bd5ab3f; #1630).
(commit: 2b522b4)
The file was modifiedsrc/plugins/miscellaneous/Core/src/centralwidget.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
Commit 788fb8bafb548718d836a7025fe4dcbb99a83c7b by Alan Garny
Removed our Simulation interface since we don't need it anymore (thanks
to commit bd5ab3f; #1630).
(commit: 788fb8b)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewsimulationwidget.cpp (diff)
Commit a309360a5461bdf9eeeea28015cdbcc98fc3d397 by Alan Garny
CellML support: have `CellmlFile::runtime()` always return a brand new
runtime (#1630).
The idea is that whoever calls `CellmlFile::runtime()` is responsible
for deleting that runtime once it’s done with it.
(commit: a309360)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
Commit 7d768fc16b3cd3a55189b3ecae7fc19f1534ac92 by Alan Garny
Simulation Experiment view: make sure that a simulation is stopped when
a saved file is to be considered as reloaded (#1630).
(commit: 7d768fc)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewwidget.cpp (diff)
Commit 055ac53356aa7d4539b146fb911e5d750d3b80f8 by Alan Garny
Simulation Experiment view: prevent the third crash in issue #1630.
(commit: 055ac53)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewsimulationwidget.cpp (diff)
Commit ce19ce381c272fdfbe9d0cfc8eccb319a0a38749 by Alan Garny
Simulation support: actually wait for our worker thread to be done when
asking our simulation to stop (#1630).
(commit: ce19ce3)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationmanager.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationmanager.cpp (diff)
Commit fe30413665626a08331371478d5941df45e3822f by Alan Garny
Simulation Experiment view: prevent the fourth crash in issue #1630.
(commit: fe30413)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewwidget.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
Commit 8e4b0c25503fecea99a56dc7aadbda9379c06d8e by Alan Garny
Simulation Experiment view: prevent the second crash in issue #1630.
(commit: 8e4b0c2)
The file was modifiedsrc/plugins/simulation/SimulationExperimentView/src/simulationexperimentviewinformationgraphpanelandgraphswidget.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationworker.cpp (diff)
Commit 7a4752a237188d12f2af027a18f118a8bb33b13d by Alan Garny
Some cleaning up.
In the end, because of what we did for issue #1630, we don’t need to
decide whether we want an elapsed time to be computed or not when asking
for a simulation to stop.
(commit: 7a4752a)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationworker.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.h (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationworker.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulation.cpp (diff)
The file was modifiedsrc/plugins/support/SimulationSupport/src/simulationworker.cpp (diff)