Simulation Experiment view: nothing should prevent us from exporting a simulation to SED-ML even if no simulation has been run (#1366). (commit: bc386c5)
Simulation Experiment view: prevent some black areas from popping up when reloading our noble_1962_remote.sedml file. Basically, the black areas pop up when we resize our busy widget. So, don’t show our busy widget when reloading the current file. Not ideal, but still better than having those black areas popping up… (commit: 8be43f1)
Graph panel widget: fixed a small problem with adding a graph panel to a SED-ML file / COMBINE archive. Indeed, say that we have 3 graph panels of different sizes and then add another graph panel. Then, all 4 graph panels used to have the same size…!? (commit: 9cefd56)
Graph panel widget: make it possible to remove the last graph panel. This is useful when we have customised a graph panel and want to start afresh. (commit: e1dba80)
SimulationExperiment view: some work on determining when a SED-ML file / COMBINE archive has been modified (and modified back) (#1366). Can now handle the addition/removal of a graph panel. (commit: 8d87217)
SimulationExperiment view: some work on determining when a SED-ML file / COMBINE archive has been modified (and modified back) (#1366). To open, say, a SED-ML file then switch to another file and then back would result in the original SED-ML file to be considered modified while it clearly shouldn’t have been. That’s because mGraphPanelPropertiesModified and mGraphsPropertiesModified were not fully set, which is important since updateFileModifiedStatus() now checks their keys… (commit: 58bfb3d)
SimulationExperiment view: some work on determining when a SED-ML file / COMBINE archive has been modified (and modified back) (#1366). Can now handle a change in the height of a graph panel. (commit: db7103c)
SimulationExperiment view: some work on determining when a SED-ML file / COMBINE archive has been modified (and modified back) (#1366). Better handle the addition/removal of a graph panel. Now, also handle the addition/removal of graphs. (commit: ea356e1)
SimulationExperiment view: some work on determining when a SED-ML file / COMBINE archive has been modified (and modified back) (#1366). Oops, forgot to have mGraphPanelPropertiesModified and mGraphsPropertiesModified properly initialised when our graph panels become visible. This meant that modifying, say, a simulation property value and change it back would result in the SED-ML file / COMBINE archive still being considered as modified. (commit: 032b200)
Simulation Experiment view: initialise some internal properties after painting ourselves as opposed to being shown for the first time (#1366). Indeed, to close a SED-ML file and have another getting active as a result was making that new SED-ML file modified… (commit: 0f00fad)
General: save as such when saving a file under a new name. Until now, if we wanted to save a non-new and non-modified file under a new name (using the “File” | “Save As…” menu), then we used to make a simple physical copy of the file. This was fine for a CellML file, but not always fine for a SED-ML (while still fine for a COMBINE archive) since the relative path to its corresponding CellML file might now be different. So, instead, we should always save a file, whether not-new and/or not-modified. (commit: 6c2735c)
Slight update to our View interface now (#1366). Indeed, the old View interface was because the Simulation Experiment view could open a CellML file, SED-ML file or COMBINE archive, but could only save a CellML file while we are going to be able to save all three types. (commit: 2fd1bf1)
Slight update to our View interface now (#1366). The idea is so that we only get the relevant MIME type when saving a file, in cases where a view supports several MIME types. Indeed, the Simulation Experiment view can open CellML files, SED-ML files and COMBINE archives, but when one of the three types has been opened, we only want to be able to save under that type. (commit: 8ccc5d7)
Graph panel widget: make sure that we provide the correct number of sizes. This came about as a result of opening https://models.physiomeproject.org/workspace/noble_1962/rawfile/c70f8962 407db00673f1fdcac9f35a2593781c17/noble_1962.sedml. That SED-ML file doesn’t use the ‘height’ property for a graph panel, so we ended up calling GraphPanelsWidget::setSizes() with an empty list of sizes, which gave our graph panel widget the impression that we didn’t have any graph panel. This meant that adding a graph panel (i.e. call GraphPanelsWidget::addGraphPanel()) would result in 1 graph panel rather than 4. On the other hand, if were to remove a graph panel (i.e. call GraphPanelsWidget::removeGraphPanel()), OpenCOR would just crash since it believed there were no graph panels. (commit: b743604)
Simulation Experiment view: improved the creation of a SED-ML file (#1366). Indeed, before, if we were to export a modified SED-ML file to a COMBINE archive (i.e. we would have a ‘*’ in the file tab text), then the ‘*’ would temporarily disappear. (commit: 1caa2e8)
![[Jenkins]](/jenkins/static/6321ab2b/images/svgs/logo.svg){kind=logo}
